-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update network selector #62
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TYSM Pablo this is really great !!!! Just pushed some commits,
Yup I think we should probably remove duplicate testnets icons nd reuse the mainnet one for them, I think its fine to have same icon for test and mainnet because we are already separating them with groups, we can always add different images for testnet if we feel so in future 🙌
Hmm yup makes sense ! I love the feature of search on desktop and we should keep it, yup on mobile its annoying :( not sure if its only for IOS but its also zoom's in the screen on mobile so makes sense to disable it for mobile, we can also keep an eye on this discussion JedWatson/react-select#3526 |
Thanks A LOT for the awesome feedback and cleaning + upgrading the code quality. Learn a lot from checking your reviews 🙌♥ |
Description
Switching regular selector for networks with
react-select
. Tried usingreact-tailwindcss-select
but did not find an easy way to add network icons to the selector. The main benefits of upgrading the selector:A few considerations to check:
That's the reason of 29a1eda. If it feels too hacky could just set
isSearchable={false}
to all devices.Related Issues
Closes #60